Skip to content

false positives. turning off for now. may revisit #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienchastang merged 1 commit into from
Mar 10, 2026
Merged

false positives. turning off for now. may revisit #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions .github/workflows/no-large-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,24 +42,26 @@ jobs:

exit "$bad"

- name: Fail on likely-binary files
run: |
set -euo pipefail
# generating false positives. May revisit
#
# - name: Fail on likely-binary files
# run: |
# set -euo pipefail

base="${{ github.event.pull_request.base.sha }}"
head="${{ github.sha }}"
# base="${{ github.event.pull_request.base.sha }}"
# head="${{ github.sha }}"

mapfile -t files < <(git diff --name-only --diff-filter=AM "$base" "$head")
# mapfile -t files < <(git diff --name-only --diff-filter=AM "$base" "$head")

bad=0
for f in "${files[@]}"; do
[ -f "$f" ] || continue
# bad=0
# for f in "${files[@]}"; do
# [ -f "$f" ] || continue

# Heuristic: if file contains NUL bytes, treat as binary
if LC_ALL=C grep -qU $'\x00' "$f"; then
echo "::error file=$f::Likely binary file (contains NUL byte)."
bad=1
fi
done
# # Heuristic: if file contains NUL bytes, treat as binary
# if LC_ALL=C grep -qU $'\x00' "$f"; then
# echo "::error file=$f::Likely binary file (contains NUL byte)."
# bad=1
# fi
# done

exit "$bad"
# exit "$bad"