Make "add time recurrence" button

changelog.d/+deprecate-api-v1.changed.md

@@ -0,0 +1,2 @@
+NOTE! Version v1 of the API is hereby deprecated! It *will* be removed one day.
+Update your glue services, please.

changelog.d/+improve-timeslots-page.changed.md

@@ -0,0 +1,2 @@
+Improved the looks and UX of the timeslots page greatly. There are still
+remaining issues.

changelog.d/+use-less-accent-color.changed.md

@@ -0,0 +1,5 @@
+Several of our easily accessible users didn't like the frequent use of the
+reddish color as an accent in the "argus" theme, they prefer reserving reddish
+hues for extra important things. We've cut down on the accent-color everywhere:
+in the incidents page we now use the primary color instead, everywhere else we
+will fall back to the default for the tailwind/daisy class.

changelog.d/1253.added.md

@@ -0,0 +1 @@
+Add borders between table rows.

changelog.d/1294.changed.md

@@ -0,0 +1 @@
+The color of the status badges to better represent either error or success state. The colors are universal across the themes.

changelog.d/1302.changed.md

@@ -0,0 +1 @@
+Show empty list instead of error if tags do not match any incidents.

docs/reference/api.rst

@@ -5,6 +5,12 @@ API Endpoints
 Endpoints, API v1
 =================
 
+.. warning::
+
+     v1 of the API is deprecated and will be removed.
+
+
+
 Authorization
 -------------
 
@@ -882,11 +888,6 @@ Notification profile endpoints
 Endpoints, API v2
 =================
 
-.. note::
-
-     v2 of the API is not stable yet.
-
-
 Authorization
 -------------
 

src/argus/auth/V1/urls.py

@@ -1,17 +1,16 @@
 from django.urls import path
 from rest_framework import routers
 
-from . import views as views_V1
-from .. import views
+from . import views as views
 
 
 router = routers.SimpleRouter()
-router.register(r"phone-number", views_V1.PhoneNumberViewV1, basename="phone_number")
+router.register(r"phone-number", views.PhoneNumberViewV1, basename="phone_number")
 
 
 app_name = "auth"
 urlpatterns = [
     # path("login/", django_views.LoginView.as_view(redirect_authenticated_user=True), name="login"),
-    path("user/", views_V1.CurrentUserViewV1.as_view(), name="current-user"),
-    path("users/<int:pk>/", views.BasicUserDetail.as_view(), name="user"),
+    path("user/", views.CurrentUserViewV1.as_view(), name="current-user"),
+    path("users/<int:pk>/", views.BasicUserDetailV1.as_view(), name="user"),
 ] + router.urls

src/argus/auth/V1/views.py

@@ -8,25 +8,37 @@
 from argus.drf.permissions import IsOwner
 from argus.notificationprofile.models import DestinationConfig
 from argus.notificationprofile.serializers import RequestDestinationConfigSerializer
+
+from ..views import BasicUserDetail
 from .serializers import RequestPhoneNumberSerializerV1, ResponsePhoneNumberSerializerV1, UserSerializerV1
 
 
 PHONE_NUMBERS_DEPRECATED = (
     "Phone numbers are now accessible through the destinations API. See /api/v2/notificationprofiles/destinations/."
 )
 
+# deprecated views unchanged from V2
+
+
+@extend_schema_view(get=extend_schema(deprecated=True))
+class BasicUserDetailV1(BasicUserDetail):
+    pass
+
+
+# overridden views
+
 
 class CurrentUserViewV1(APIView):
     permission_classes = [IsAuthenticated]
     serializer_class = UserSerializerV1
 
+    @extend_schema(deprecated=True)
     def get(self, request, *args, **kwargs):
         serializer = self.serializer_class(request.user)
         return Response(serializer.data)
 
 
 @extend_schema_view(
-    deprecated=True,
     list=extend_schema(
         deprecated=True,
         description=PHONE_NUMBERS_DEPRECATED,

src/argus/htmx/incident/filter.py

@@ -51,7 +51,7 @@ class IncidentFilterForm(forms.Form):
         widget=forms.TextInput(
             attrs={
                 "placeholder": "key=value, ...",
-                "class": "input input-accent input-bordered input-md border overflow-y-auto min-h-8 h-auto max-h-16 max-w-xs leading-tight",
+                "class": "input input-primary input-bordered input-md border overflow-y-auto min-h-8 h-auto max-h-16 max-w-xs leading-tight",
             }
         ),
         required=False,
@@ -79,18 +79,11 @@ def clean_tags(self):
             return None
 
         try:
-            tags_list = set(tag.strip() for tag in tags.split(","))
-            tags_qss = Tag.objects.parse(*tags_list)
+            for tag in tags.split(","):
+                Tag.split(tag.strip())
         except ValueError:
             raise forms.ValidationError("Tags need to have the format key=value, key2=value2")
 
-        existing_tags = set()
-        for tags_qs in tags_qss:
-            existing_tags.update(set(str(tag) for tag in tags_qs))
-        missing_tags = tags_list - existing_tags
-        if missing_tags:
-            raise forms.ValidationError(f"The following tags could not be found: {', '.join(missing_tags)}")
-
         return tags
 
     def _tristate(self, onkey, offkey):

src/argus/htmx/notificationprofile/views.py

@@ -80,7 +80,7 @@ def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
         self.fields["timeslot"].queryset = Timeslot.objects.filter(user=self.user)
-        self.fields["active"].widget.attrs["class"] = "checkbox checkbox-sm checkbox-accent border"
+        self.fields["active"].widget.attrs["class"] = "checkbox checkbox-sm border"
         self.fields["active"].widget.attrs["autocomplete"] = "off"
         self.fields["name"].widget.attrs["class"] = "input input-bordered"