Skip to content

Conversation

@hmpf
Copy link
Contributor

@hmpf hmpf commented Nov 24, 2025

Scope and purpose

This makes the create/update/delete part of the filter box take up less space and changes the behavior of the widget so that update/delete no longer has a drop down but works on the already selected stored filter.

Screenshots

Before:

image

After:

image image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@hmpf hmpf requested review from a team and Simrayz November 24, 2025 07:47
@hmpf hmpf self-assigned this Nov 24, 2025
@hmpf hmpf moved this from 📋 Backlog to 🏗 In progress in Argus development, public Nov 24, 2025
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Test results

    4 files    520 suites   19m 47s ⏱️
  622 tests   621 ✅ 1 💤 0 ❌
2 488 runs  2 484 ✅ 4 💤 0 ❌

Results for commit 9eea3be.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Simrayz Simrayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, and it works well. Nice 😄

@hmpf hmpf force-pushed the shrink-stored-filter-widget branch from 810932f to 6e6d225 Compare November 26, 2025 09:01
@hmpf hmpf marked this pull request as ready for review November 26, 2025 09:01
@hmpf hmpf force-pushed the shrink-stored-filter-widget branch from 6e6d225 to badbae2 Compare November 26, 2025 09:01
@hmpf hmpf requested a review from a team November 26, 2025 11:09
@hmpf hmpf moved this from 🏗 In progress to ❓ Ready for review in Argus development, public Nov 26, 2025
@hmpf hmpf force-pushed the shrink-stored-filter-widget branch 6 times, most recently from 6482a4f to 9839d44 Compare November 26, 2025 13:48
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 54.44444% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.56%. Comparing base (26cf5d7) to head (9eea3be).

Files with missing lines Patch % Lines
src/argus/htmx/incident/views.py 28.84% 37 Missing ⚠️
src/argus/htmx/incident/filter.py 89.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1621      +/-   ##
==========================================
- Coverage   79.68%   79.56%   -0.13%     
==========================================
  Files         132      132              
  Lines        6113     6160      +47     
==========================================
+ Hits         4871     4901      +30     
- Misses       1242     1259      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hmpf added 4 commits November 28, 2025 11:53
.. also added the name of each involved template to that template as an
html comment, for ease of debugging.
@hmpf hmpf force-pushed the shrink-stored-filter-widget branch from 9839d44 to 9eea3be Compare November 28, 2025 10:53
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

3 participants