-
Notifications
You must be signed in to change notification settings - Fork 15
Shrink stored filter widget on incident list #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test results 4 files 520 suites 19m 47s ⏱️ Results for commit 9eea3be. ♻️ This comment has been updated with latest results. |
Simrayz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested manually, and it works well. Nice 😄
810932f to
6e6d225
Compare
6e6d225 to
badbae2
Compare
6482a4f to
9839d44
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1621 +/- ##
==========================================
- Coverage 79.68% 79.56% -0.13%
==========================================
Files 132 132
Lines 6113 6160 +47
==========================================
+ Hits 4871 4901 +30
- Misses 1242 1259 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.. also added the name of each involved template to that template as an html comment, for ease of debugging.
9839d44 to
9eea3be
Compare
|



Scope and purpose
This makes the create/update/delete part of the filter box take up less space and changes the behavior of the widget so that update/delete no longer has a drop down but works on the already selected stored filter.
Screenshots
Before:
After:
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.