-
Notifications
You must be signed in to change notification settings - Fork 15
Add version number to frontend #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Test results 4 files 524 suites 19m 38s ⏱️ Results for commit c0610b8. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
- Coverage 79.44% 79.37% -0.07%
==========================================
Files 129 129
Lines 6017 6032 +15
==========================================
+ Hits 4780 4788 +8
- Misses 1237 1244 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -1,4 +1,5 @@ | |||
| <ul class="z-20 menu menu-md dropdown-content bg-base-200 text-base-content rounded-box z-[1] mt-3 w-52 p-2 shadow max-h-svh"> | |||
| <li>Argus version: {{ version }}</li> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the version is too visible if put at the top, and seeing as it is a "tertiary" action, it is probably best put at the bottom.
Here is a suggested menu item (with a divider on top):
<li>
<div class="divider divider-secondary pl-2 pr-4 my-0 pointer-events-none"></div>
<button class="text-xs" onclick="navigator.clipboard.writeText('{{ version }}')">
<div class="space-y-2">
<span>Argus version:</span>
<span class="truncate">{{ version }}</span>
</div>
<i class="fa-solid fa-copy"></i>
</button>
</li>There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we ever have a version number like that in prod, that's the bug, not how it is rendered :)
hmpf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One liner fixes...
|
What will it look like when not logged in? |
Co-authored-by: Hanne Moa <[email protected]>
At the moment it is not present at all when not logged in due to the user menu requiring an authenticated user. |
|
When not logged in (check with user.is_authenticated in the template), put it to the left of the login button in the login template. If anyone complains we can move it later (but what we need is an actual about-page.. out of scope.) |
|
Yes, I agree that it should also be visible somewhere when not logged in - in the case that we ever break the login mechanism |
johannaengland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nitpicks here about the code, looks-wise I'm happy :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to look good, just some small suggestions now :)
Co-authored-by: Simen Abelsen <[email protected]>
|










Scope and purpose
Fixes #1650 .
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.