Skip to content

Replace Radioplayer button with an in-page player #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: development
Choose a base branch
from
Draft

Replace Radioplayer button with an in-page player #356

wants to merge 18 commits into from

Conversation

@ashhhleyyy
Copy link
Member

@ashhhleyyy ashhhleyyy commented May 24, 2024

The URY Player(tm)

@ashhhleyyy
Copy link
Member Author

ashhhleyyy commented May 24, 2024 •
edited
Loading

Things still to do:

  • Show current time from playback (including the 15s online delay)
  • Scrubbing support through the local buffer
  • Close button
  • Make send message form not refresh the page

Update: removed scrubbing support from this initial version

@ashhhleyyy
Copy link
Member Author

ashhhleyyy commented May 27, 2024

Just needs some fixup on the mobile CSS (or alternatively, just use radioplayer on mobile)

@ashhhleyyy
Copy link
Member Author

ashhhleyyy commented May 28, 2024

Here's what the final thing looks like:
image

And on mobile:
image

@ashhhleyyy ashhhleyyy marked this pull request as ready for review May 28, 2024 00:04
@alyxbb
Copy link
Contributor

alyxbb commented May 28, 2024

is the send message updates a duplicate of #292?

@alyxbb alyxbb linked an issue Jun 12, 2024 that may be closed by this pull request
Send message not clear message has sent #126
Open
@ashhhleyyy
Copy link
Member Author

ashhhleyyy commented Oct 9, 2024

rebased onto development to fix merge conflicts

ColinRoitt
ColinRoitt reviewed Oct 16, 2024
View reviewed changes
@ColinRoitt
Copy link
Contributor

ColinRoitt commented Oct 17, 2024

Made a few changes, @ashhhleyyy would you check you're happy with these then and we can count that as reviewing both ways

image

image

ashhhleyyy
ashhhleyyy commented Nov 6, 2024
View reviewed changes
Copy link
Member Author

@ashhhleyyy ashhhleyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to make a couple tweaks then this should probably be good to go

public/js/live-player.js Outdated
});

window.onbeforeunload = () => {
console.log('before unload');
Copy link
Member Author

@ashhhleyyy ashhhleyyy Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@ashhhleyyy ashhhleyyy marked this pull request as draft November 6, 2024 16:31
@ashhhleyyy
Copy link
Member Author

ashhhleyyy commented Nov 6, 2024

  • show more button on the current and next
  • webcam somewhere
  • better contrast on close button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ColinRoitt ColinRoitt ColinRoitt left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Send message not clear message has sent

4 participants

@ashhhleyyy @alyxbb @ColinRoitt