Initial work on h264 chunked mode (decoding before getting full frame)#555
Open
funman wants to merge 2 commits intoUpipe:masterfrom
Open
Initial work on h264 chunked mode (decoding before getting full frame)#555funman wants to merge 2 commits intoUpipe:masterfrom
funman wants to merge 2 commits intoUpipe:masterfrom
Conversation
This avoid outputting wrong offsets if the next frame has less NALs
funman
changed the title
This is needed if several input urefs are needed to output a frame, for example when settings flags2 to chunks with h264
Collaborator
|
I think the reason we kepts a copy of the uref as long as possible was that avcodec sometimes requests a buffer with no reason. Are you sure there is no regression with this patch? |
Contributor
Author
|
We are still keeping a uref, it's just the first of N urefs until a buffer is getting output. |
Contributor
|
ping |
Collaborator
|
Is this pull request still necessary? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.