USB Protection Improvement and ExamMode Fix#111
USB Protection Improvement and ExamMode Fix#111devdl11 wants to merge 23 commits intoUpsilonNumworks:upsilon-devfrom
Conversation
…BLING THE PROTECTION** ⚠⚠ in order to fix epsilon_ flash (very dangerous thing !!)
|
| #if ION_SIMULATOR_FILES | ||
| mode = GlobalPreferences::ExamMode::Off; | ||
| #else |
There was a problem hiding this comment.
I think these lines should be removed, because this pull request is marked as ready for review
There was a problem hiding this comment.
I don't know because it add the possibility to disable the exam mode in the simulator without rebooting
There was a problem hiding this comment.
Yes, but it is marked as ready to merge…
There was a problem hiding this comment.
Indeed because I think it can be a good idea to add the possibility to disable the exam mode in simulators ^^ The exam mode in simulator doesn't make any sense in the first place because you can always leave the simulator and open others app so I don't see the problem by adding the option
There was a problem hiding this comment.
Yes, but if we look #131, it is built as a simulator, but it runs on the calculator…
apps/shared/function.h
Outdated
| } | ||
| bool isActive() const { return m_active; } | ||
| void setActive(bool active) { m_active = active; } | ||
| void setMyColor(KDColor color) {m_color = color; } |
There was a problem hiding this comment.
| void setMyColor(KDColor color) {m_color = color; } | |
| void setMyColor(KDColor color) { m_color = color; } |
There was a problem hiding this comment.
In fact, is it possible to give a better name to the function?
ion/src/device/shared/boot/rt0.cpp
Outdated
|
|
||
| /* Call static C++ object constructors | ||
| * The C++ compiler creates an initialization function for each static object. | ||
| * The C++ compiler creates an initialization function for each static object. |
There was a problem hiding this comment.
| * The C++ compiler creates an initialization function for each static object. | |
| * The C++ compiler creates an initialization function for each static object. |
| // Leave DFU routine: Leave DFU, reset device, jump to application code | ||
| leaveDFUAndReset(); | ||
| } else if (m_state == State::dfuDNBUSY) { | ||
| m_state = State::dfuDNBUSY; |
There was a problem hiding this comment.
I don't understand this line...
| void DFUInterface::eraseCommand(uint8_t *transferBuffer, uint16_t transferBufferLength) { | ||
| /* We determine whether the commands asks for a mass erase or which sector to | ||
| * erase. The erase must be done after the next getStatus request. */ | ||
| * erase. The erase must be done after the next getStatus request. */ |
There was a problem hiding this comment.
I think it has been squashed when merging, but this fork isn't up-to-date, so it isn't corrected in this repo
| /* We decided to never protect Read operation. Else we would have to check | ||
| * here it is not protected before reading. */ | ||
|
|
||
|
| // #if ION_SIMULATOR_FILES | ||
| // mode = GlobalPreferences::ExamMode::Off; | ||
| // #else | ||
| mode = GlobalPreferences::sharedGlobalPreferences()->examMode(); | ||
| // #endif |
There was a problem hiding this comment.
I think these comments can be removed.
| return; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Remove trailing space…
|
I think this pull request have to be updated, because #205 remove the USB protection… |
|
I close this pull request because it's too outdated to be merged, a completed rework needs to be made |
3 participants
Some little improvements preparing the release