Open
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/8613/2a772972f05c678f7e2f3860e6479c818c4b3e1c/pkg/@vkontakte/vkui/_pkg.tgzCommit 2a77297 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8613 +/- ##
==========================================
- Coverage 95.31% 95.29% -0.03%
==========================================
Files 441 454 +13
Lines 12097 12316 +219
Branches 4405 4430 +25
==========================================
+ Hits 11530 11736 +206
- Misses 567 580 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SevereCloud
force-pushed
the
SevereCloud/feat/unstable_ExpressiveSpinner
branch
2 times, most recently
from
32ea240 to
7e740ae
Compare
vkcom-publisher
added
pr-needs-work
vkcom-publisher
added
the
pr-needs-work
Contributor
|
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
SevereCloud
added
the
no-stale
SevereCloud
removed
the
pr-needs-work
SevereCloud
force-pushed
the
SevereCloud/feat/unstable_ExpressiveSpinner
branch
from
7e740ae to
8480b10
Compare
Contributor
SevereCloud
force-pushed
the
SevereCloud/feat/unstable_ExpressiveSpinner
branch
from
8480b10 to
118736d
Compare
SevereCloud
force-pushed
the
SevereCloud/feat/unstable_ExpressiveSpinner
branch
from
118736d to
251f437
Compare
Contributor
|
нужен ребейз |
SevereCloud
force-pushed
the
SevereCloud/feat/unstable_ExpressiveSpinner
branch
from
251f437 to
2a77297
Compare
| import { type MaterialSpinnerProps, Spinner } from './Spinner'; | ||
|
|
||
| const story: Meta<MaterialSpinnerProps> = { | ||
| title: 'Blocks/Spinner/Expressive', |
Contributor
There was a problem hiding this comment.
Suggested change
| title: 'Blocks/Spinner/Expressive', | |
| title: 'Feedback/Spinner/Expressive', |
Comment on lines
+20
to
+24
| const callbackRef = React.useRef(callback); | ||
|
|
||
| React.useEffect(() => { | ||
| callbackRef.current = callback; | ||
| }, [callback]); |
Contributor
There was a problem hiding this comment.
Suggested change
| const callbackRef = React.useRef(callback); | |
| React.useEffect(() => { | |
| callbackRef.current = callback; | |
| }, [callback]); | |
| const stableCallback = useStableCallback(callback); |
Comment on lines
+100
to
+114
| ## unstable_ExpressiveSpinner | ||
|
|
||
| Нестабильный компонент индикации загрузки в стиле | ||
| [M3 Expressive](https://m3.material.io/components/loading-indicator/overview). | ||
| Принимает все свойства, которые принимает компонент `Spinner`. | ||
| Для платформы `ios` используется обычный `Spinner`. | ||
|
|
||
| <Playground> | ||
| ```jsx | ||
| import { unstable_ExpressiveSpinner as ExpressiveSpinner} from "@vkontakte/vkui"; | ||
|
|
||
| <ExpressiveSpinner size="xl" /> | ||
| ``` | ||
| </Playground> | ||
|
|
Contributor
There was a problem hiding this comment.
Может добавить тут в примере или в отдельный, как полигоны прокидывать , а то может быть непонятно
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| export const unstable_ExpressiveSpinner = Spinner; |
Contributor
There was a problem hiding this comment.
Вроде обычно приставку unstable_ добавляем при экмпорте из пакета. Еще не совсем понял, почему в папке ExpressiveSpinner файлы с именем Spinner. Не будет ли путаницы при поиске?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Добавляем библиотеку интерполяции между svg-шками и спиннер из m3
2026-03-03.12.44.29.mov
Release notes
Новые компоненты
ExpressiveSpinner.mov