RFC 7208: 5.2, none result should be returned as "no match"#58
Open
ahmeij wants to merge 1 commit into
Open
Conversation
taylorrf
requested changes
May 19, 2026
Comment on lines
+13
to
+19
| # RFC 7208: 5.2, none result should be returned as "no match" | ||
| # def evaluate_none_result(result, m, r) | ||
| # new_result = super | ||
| # return new_result unless new_result.none? | ||
|
|
||
| raise Coppertone::NoneIncludeResultError | ||
| end | ||
| # raise Coppertone::NoneIncludeResultError | ||
| # end |
Contributor
There was a problem hiding this comment.
Is it possible to add a spec covering this RFC 7208: 5.2 case, and rebase it with our current main branch?
Also, I was wondering if, instead of commenting on this method, we can actually handle the result argument and return a no match.
Thanks for your PR! And let me know what you think about the suggestions above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When including an external SPF record with
includethe RFC explicitly allows the result to be empty (?all does not need to be present).Currently when including an SPF record with only ip addresses and no
alldirective the validation will result in apermerror.This PR removes the check and allows 'none' as a result.