vlagent: use single volume for all vlagent data by default#1705
Merged
AndrewChubatiuk merged 1 commit intomasterfrom Jan 21, 2026
Merged
vlagent: use single volume for all vlagent data by default#1705AndrewChubatiuk merged 1 commit intomasterfrom
AndrewChubatiuk merged 1 commit intomasterfrom
Conversation
AndrewChubatiuk
requested review from
Haleygo,
f41gh7 and
vrutkovs
as code owners
AndrewChubatiuk
force-pushed
the
vlagent-tmp-data-path
branch
7 times, most recently
from
9d7f4b6 to
537bb46
Compare
AndrewChubatiuk
force-pushed
the
vlagent-tmp-data-path
branch
from
537bb46 to
d47f77a
Compare
AndrewChubatiuk
force-pushed
the
vlagent-tmp-data-path
branch
from
d47f77a to
991fac7
Compare
AndrewChubatiuk
force-pushed
the
vlagent-tmp-data-path
branch
2 times, most recently
from
dc3a3bd to
b890fed
Compare
AndrewChubatiuk
force-pushed
the
vlagent-tmp-data-path
branch
from
b890fed to
f74ed1a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vrutkovs
requested changes
Jan 15, 2026
| // Path to directory where temporary data for remote write component is stored (default /vlagent_pq/vlagent-remotewrite-data) | ||
| // If defined, operator ignores spec.storage field and skips adding volume and volumeMount for pq | ||
| // Path to directory where temporary data for remote write component is stored. | ||
| // Defaults to /vlagent-data/vlagent-remotewrite-data or /var/lib/vlagent-data/vlagent-remotewrite-data in collector mode |
Collaborator
There was a problem hiding this comment.
If undefined defaults to /var/lib/vlagent-data
Contributor
Author
There was a problem hiding this comment.
value in PR is correct, this is spec.remoteWriteSettings.tmpData, which is a data path for remote write data
| if ptr.Deref(cr.Spec.K8sCollector.IncludePodLabels, true) { | ||
| args = append(args, "-kubernetesCollector.includePodLabels") | ||
| } | ||
| if ptr.Deref(cr.Spec.K8sCollector.IncludePodAnnotations, false) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ptr.Deref(cr.Spec.K8sCollector.IncludePodAnnotations, false) { | |
| if ptr.Deref(cr.Spec.K8sCollector.IncludePodAnnotations, true) { |
We should not be setting this flag if its unset, right?
Contributor
Author
There was a problem hiding this comment.
kept it's value the same as vlagent has
vrutkovs
approved these changes
Jan 21, 2026
AndrewChubatiuk
force-pushed
the
vlagent-tmp-data-path
branch
from
3f2efd0 to
50b5402
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1696