-
-
Notifications
You must be signed in to change notification settings - Fork 275
Add TypeScript — Getting Started Resource Page #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add TypeScript — Getting Started Resource Page #1430
Conversation
👷 Deploy Preview for virtual-coffee-io processing.
|
adiati98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Technozamazing, you get off to a good start! This looks good. ✨
I've left some reviews here for you to address.
For this instruction: Cover basic TypeScript concepts (types, interfaces, generics), it'd be great if we could have this kind of structure:
## TITLE
[Brief explanation about the section]
[General code examples]
[Examples from the real VC codebase]So, we give the real VC codebase example for each types, interfaces, generics.
Please let us know if you have any questions or need help.
src/content/resources/developer-resources/typescript/typescript-getting-started.mdx
Outdated
Show resolved
Hide resolved
src/content/resources/developer-resources/typescript/typescript-getting-started.mdx
Outdated
Show resolved
Hide resolved
src/content/resources/developer-resources/typescript/typescript-getting-started.mdx
Outdated
Show resolved
Hide resolved
src/content/resources/developer-resources/typescript/typescript-getting-started.mdx
Outdated
Show resolved
Hide resolved
src/content/resources/developer-resources/typescript/typescript-getting-started.mdx
Outdated
Show resolved
Hide resolved
src/content/resources/developer-resources/typescript/typescript-getting-started.mdx
Outdated
Show resolved
Hide resolved
src/content/resources/developer-resources/typescript/typescript-getting-started.mdx
Outdated
Show resolved
Hide resolved
BekahHW
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Technozamazing if you can address @adiati98's feedback, I think we can add an #hacktoberfestaccepted tag to your PR and can work on getting your PR where it needs to be for our resources if you're up for it.
Co-authored-by: Ayu Adiati <[email protected]>
Co-authored-by: Ayu Adiati <[email protected]>
Co-authored-by: Ayu Adiati <[email protected]>
Co-authored-by: Ayu Adiati <[email protected]>
Co-authored-by: Ayu Adiati <[email protected]>
Co-authored-by: Ayu Adiati <[email protected]>
Co-authored-by: Ayu Adiati <[email protected]>
Removed the Appreciation section from the TypeScript guide.
|
I have revised the resource with the requested formatting and omitted the Appreciation section from the index. |
Technozamazing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback!
Hope the changes meets the requirements.
|
@Technozamazing thanks so much for addressing the feedback! I'm going to add the However, we'll take a closer look at this PR so we can merge it in once it's completely done. |
Linked Issue #1408
This PR adds a new resource page: TypeScript – Getting Started.
It’s written to be beginner-friendly and follows the existing resource layout.
fixes: #1408
What’s Included
.mdxfile as requestedChecklist
.mdxfilePreview of what's done
Code of Conduct