Adds password as argument for Thincast RDP launch #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the logic for launching Thincast to pass the password as a command-line argument instead of writing it unencrypted to the RDP file. Improves security by avoiding plaintext password storage and ensures compatibility with Thincast's CLI options. Adjusts debug logging accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the way RDP connection scripts for macOS handle passwords and command-line arguments, improving security and compatibility with Thincast and xfreerdp clients. The changes remove the practice of writing passwords into RDP files and instead pass them securely as command-line arguments. This approach reduces the risk of exposing sensitive information and aligns with best practices.
Security and password handling improvements:
Stopped writing the RDP password in plain text to the
.rdpfile in bothdirect.pyandtunnel.py; instead, the password is now appended as a command-line argument (/p:<password>) when launching Thincast, if provided. [1] [2]For xfreerdp/udsrdp, added logic to append the
/p:<password>argument to the command if a password is present, ensuring consistent password handling across clients.Signature updates:
.signaturefiles for bothdirect.pyandtunnel.pyto reflect the code changes. [1] [2]