Remove _noop.noop() and call upon eval("None") to try and deliver the same result after a KeyboardInterrupt
#109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Important
This is currently is an idea that is still under concept and was the result of needing to solve an issue related to dependencies and optimizing signal execution.
My main reason for getting rid of
_noop.noophas to do with pyinstaller and the amount of hurdles needed to be jumped just to get winloop to comply with pyinstaller hooks is just not wroth the time and resources they made it into a nightmare to try and add new things to it also making the process a little more annoying than it needs to be.Because python needs something to evaluate my idea was invoking
_PyEval_FrameDefaultby calling uponevalto try and attempt to deliver the same results.I would like to get a maintainer from uvloop to look at this or explain to be why this is good or bad before I continue to merge this since I wanted to make sure that if I do go for this implementation that the uvloop maintainers and contributors will follow my lead on this important upgrade.
I'll throw in an issue about this on uvloop's github repo if I do not hear back about this idea when I get home from work today.
Are there changes in behavior for the user?
This should revert some older changes and make ceval equal to what it was originally when CTRL+C is hit.
Is it a substantial burden for the maintainers to support this?
Related issue number
Fixes #58
Checklist