Fix race conditions on loop._ready_len
#110
Merged
+2
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a simple PR that fixes MagicStack/uvloop#720 by removing
loop._ready_lenin favor oflen(loop._ready). The attribute was probably added as a premature optimization (it does not affect performance even in edge cases), but it leads to race conditions both between worker threads callingloop.call_soon_threadsafe()and between any such worker thread and the event loop, sinceloop._ready_lenis updated in a non-thread-safe manner (free-threading).Are there changes in behavior for the user?
Since the attribute is not public (and according to GitHub search, it has never been used by anyone else), no.
Is it a substantial burden for the maintainers to support this?
No, this PR mirrors MagicStack/uvloop#721.
Checklist