Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 1, 2025

Description

Fixes theme selection issues from #2363 (bugs 4-6):

Changes

Theme preference handling (AppearanceItems.vue, Context.ts):

  • darkModel now reads/writes Settings.theme ('dark'|'light'|'system') instead of boolean isDark
  • Added MediaQueryList listener for prefers-color-scheme changes
  • Applied listener globally in Context.ts so system theme changes work even when settings panel is closed
// Before: lost 'system' preference
get: () => isDark.value ? 'dark' : 'light',
set: v => { isDark.value = window.matchMedia('(prefers-color-scheme: dark)').matches }

// After: persists 'system' and reacts to OS changes
get: () => settingsState.value?.theme ?? 'dark',
set: (v: 'dark' | 'light' | 'system') => {
  settingsState.value?.themeSet(v)
  applyThemePreference(v)
}

Locale updates (en, zh-CN, zh-TW, ja-JP, ko):

  • Updated darkThemeDescription to include "follow system" option
Original prompt

This section details on the original issue you should resolve

<issue_title>莫名其妙的 bug 过多,急需打磨产品体验</issue_title>
<issue_description>### 是否已经有人报告过这个问题?

  • 我已经搜索过现有的问题

启动器版本

0.52.7

操作系统

Mac

架构

x64

当前行为

虽然能用,但是奇怪的 bug 过多。比如

  1. app 会创建 ~/Library/Preferences/xmcl.plist 文件作为配置文件,跟官网的说法不符。我说我想从头配置一下,怎么都删不干净配置文件,原来这里还藏了一个。
  2. 一上来就莫名其妙创建一个 1.21.8 的实例。无可厚非,但是很莫名其妙。
  3. 第一次打开设置,老是提示这玩意:
Image
  1. 设置里面,改变主题选择的时候,如果当前是亮色主题,点开下拉框,点“跟随系统”,实际上选择的却是“暗色主题”?

Image

  1. 还是主题选择,当我选择“跟随系统”时,即使我的系统是亮色主题,仍要给我显示为暗色?
  2. 还是主题选择,左边说“选择深色或浅色主题”,右边下拉框却是“亮色主题”,两边说法不一致。
  3. 当窗口比较小时,文字就会重叠。
Image
  1. 这个不算 bug,但是!滥用过渡动画效果!导致整个操作流程黏糊糊的,就像是在浆糊里面走路。有一些操作明明就是跳转一个页面,也不涉及网络加载,也要过度一秒钟,比如打开实例设置,这些页面都是写死的代码,又不需要网络加载,你给他一秒的过渡动画有什么意义?

期望行为

No response

复现步骤

No response

其他信息?

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

@BANSAFAn > ### 是否已经有人报告过这个问题? > * [x] 我已经搜索过现有的问题 > > ### 启动器版本 > 0.52.7 > > ### 操作系统 > Mac > > ### 架构 > x64 > > ### 当前行为 > 虽然能用,但是奇怪的 bug 过多。比如 > > 1. app 会创建 ~/Library/Preferences/xmcl.plist 文件作为配置文件,跟官网的说法不符。我说我想从头配置一下,怎么都删不干净配置文件,原来这里还藏了一个。 > 2. 一上来就莫名其妙创建一个 1.21.8 的实例。无可厚非,但是很莫名其妙。 > 3. 第一次打开设置,老是提示这玩意: > > Image > 4. 设置里面,改变主题选择的时候,如果当前是亮色主题,点开下拉框,点“跟随系统”,实际上选择的却是“暗色主题”? > > ![Image](https://github.com/user-attachments/assets/3aeccb9f-f439-476e-9c51-46c195cdaad0) [ ![Image](https://github.com/user-attachments/assets/3aeccb9f-f439-476e-9c51-46c195cdaad0) ](https://private-user-images.githubusercontent.com/10379994/507143977-3aeccb9f-f439-476e-9c51-46c195cdaad0.gif?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjE5Mzc3OTcsIm5iZiI6MTc2MTkzNzQ5NywicGF0aCI6Ii8xMDM3OTk5NC81MDcxNDM5NzctM2FlY2NiOWYtZjQzOS00NzZlLTljNTEtNDZjMTk1Y2RhYWQwLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEwMzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMDMxVDE5MDQ1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU0MGJkMjUzZDQ2YjViNWNhNzQ0OWU3NTZlZWU1NGEyODQ1NjQyMjRkMmRhMmYxNTk1MDMyMDk2YjU5NjU3YjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Pq8NNKFFHPr6HfBx1hqRw1Uu1Xl5-1qfzHyAfYZTaAs) [ ](https://private-user-images.githubusercontent.com/10379994/507143977-3aeccb9f-f439-476e-9c51-46c195cdaad0.gif?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjE5Mzc3OTcsIm5iZiI6MTc2MTkzNzQ5NywicGF0aCI6Ii8xMDM3OTk5NC81MDcxNDM5NzctM2FlY2NiOWYtZjQzOS00NzZlLTljNTEtNDZjMTk1Y2RhYWQwLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEwMzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMDMxVDE5MDQ1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU0MGJkMjUzZDQ2YjViNWNhNzQ0OWU3NTZlZWU1NGEyODQ1NjQyMjRkMmRhMmYxNTk1MDMyMDk2YjU5NjU3YjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Pq8NNKFFHPr6HfBx1hqRw1Uu1Xl5-1qfzHyAfYZTaAs) > > 5. 还是主题选择,当我选择“跟随系统”时,即使我的系统是亮色主题,仍要给我显示为暗色? > 6. 还是主题选择,左边说“选择深色或浅色主题”,右边下拉框却是“亮色主题”,两边说法不一致。 > 7. 当窗口比较小时,文字就会重叠。 > > Image2 minute survey.

Copilot AI changed the title [WIP] Fix various bugs affecting product experience Fix theme selection bugs: properly persist and apply system theme preference Dec 1, 2025
Copilot AI requested a review from ci010 December 1, 2025 15:57
Copilot finished work on behalf of ci010 December 1, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants