Skip to content

Update README.md to use precommit handlers instead of after-transition #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 13, 2025
Merged

Update README.md to use precommit handlers instead of after-transition #281

merged 6 commits into from
Mar 13, 2025

Conversation

@noamr
Copy link
Contributor

@noamr noamr commented Mar 11, 2025

No description provided.

@noamr
Copy link
Contributor Author

noamr commented Mar 11, 2025

@domenic PTAL?

bramus
bramus reviewed Mar 11, 2025
View reviewed changes
@noamr @bramus
Update README.md
21421c3 
Co-authored-by: Bramus <[email protected]>
domenic
domenic reviewed Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions. This is nice!

@noamr
Copy link
Contributor Author

noamr commented Mar 12, 2025

LGTM with minor suggestions. This is nice!

Thanks! Can you add me as a contributor to this repo or approve the PR officially please :)?

@domenic domenic merged commit fd8bf85 into WICG:main Mar 13, 2025
2 checks passed
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 27, 2025
@natechapin @chromium-wpt-export-bot
Update navigation API deferred commit prototype to use new precommitH…
3ea4b87 
…andler mechanism

Explainer updates:
WICG/navigation-api#281
WICG/navigation-api#282

Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Mar 27, 2025
Merged
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 27, 2025
@natechapin
Update navigation API deferred commit prototype to use new precommitH…
71ee6c1 
…andler mechanism

Explainer updates:
WICG/navigation-api#281
WICG/navigation-api#282

Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382278
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Noam Rosenthal <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1438913}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 27, 2025
@natechapin @chromium-wpt-export-bot
Update navigation API deferred commit prototype to use new precommitH…
f01523e 
…andler mechanism

Explainer updates:
WICG/navigation-api#281
WICG/navigation-api#282

Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382278
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Noam Rosenthal <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1438913}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 27, 2025
@natechapin @chromium-wpt-export-bot
Update navigation API deferred commit prototype to use new precommitH…
bbc20dc 
…andler mechanism

Explainer updates:
WICG/navigation-api#281
WICG/navigation-api#282

Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382278
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Noam Rosenthal <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1438913}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 29, 2025
@natechapin @moz-wptsync-bot
Bug 1956929 [wpt PR 51661] - Update navigation API deferred commit pr…
783ad5a 
…ototype to use new precommitHandler mechanism, a=testonly

Automatic update from web-platform-tests
Update navigation API deferred commit prototype to use new precommitHandler mechanism

Explainer updates:
WICG/navigation-api#281
WICG/navigation-api#282

Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382278
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Noam Rosenthal <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1438913}

--

wpt-commits: bbc20dc7df7a051b0f5e710671dbc7c71d378d61
wpt-pr: 51661
glandium pushed a commit to mozilla-firefox/firefox that referenced this pull request Apr 1, 2025
@natechapin @moz-wptsync-bot
Bug 1956929 [wpt PR 51661] - Update navigation API deferred commit pr…
0cbccdd 
…ototype to use new precommitHandler mechanism, a=testonly

Automatic update from web-platform-tests
Update navigation API deferred commit prototype to use new precommitHandler mechanism

Explainer updates:
WICG/navigation-api#281
WICG/navigation-api#282

Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382278
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Noam Rosenthal <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1438913}

--

wpt-commits: bbc20dc7df7a051b0f5e710671dbc7c71d378d61
wpt-pr: 51661
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Apr 1, 2025
@natechapin @moz-wptsync-bot
Bug 1956929 [wpt PR 51661] - Update navigation API deferred commit pr…
f6f38b7 
…ototype to use new precommitHandler mechanism, a=testonly

Automatic update from web-platform-tests
Update navigation API deferred commit prototype to use new precommitHandler mechanism

Explainer updates:
WICG/navigation-api#281
WICG/navigation-api#282

Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382278
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Noam Rosenthal <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1438913}

--

wpt-commits: bbc20dc7df7a051b0f5e710671dbc7c71d378d61
wpt-pr: 51661
aosmond pushed a commit to aosmond/gecko that referenced this pull request Apr 4, 2025
@natechapin @moz-wptsync-bot
Bug 1956929 [wpt PR 51661] - Update navigation API deferred commit pr…
73d0d07 
…ototype to use new precommitHandler mechanism, a=testonly

Automatic update from web-platform-tests
Update navigation API deferred commit prototype to use new precommitHandler mechanism

Explainer updates:
WICG/navigation-api#281
WICG/navigation-api#282

Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382278
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Noam Rosenthal <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1438913}

--

wpt-commits: bbc20dc7df7a051b0f5e710671dbc7c71d378d61
wpt-pr: 51661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic left review comments

+1 more reviewer

@bramus bramus bramus left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noamr @bramus @domenic