This repository was archived by the owner on Nov 13, 2025. It is now read-only.
Fix: invalid urls passed to tomcat result in stacktraces#66
Open
ThomBreugelmans wants to merge 1 commit intomasterfrom
Open
Fix: invalid urls passed to tomcat result in stacktraces#66ThomBreugelmans wants to merge 1 commit intomasterfrom
ThomBreugelmans wants to merge 1 commit intomasterfrom
Conversation
Tomcat does not like getting invalid URLs that do not follow the RFC, so an URL like: https://connect.ch.tudelft.nl/\?f\=\[ will result in an error and by default Tomcat will print a stacktrace along with server information such as version. Added a Valve in the server.xml config that disables these error reports and server information.
07joshua03
approved these changes
Oct 30, 2025
07joshua03
left a comment
07joshua03
left a comment
There was a problem hiding this comment.
Geen flauw idee waar ik naar aan het kijken ben (of hoe het origineel eruit zag), maar als het ervoor zorgt dat we geen security disclosure mailtjes meer krijgen vind ik het goed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tomcat does not like getting invalid URLs that do not follow the RFC, so an URL like:
https://connect.ch.tudelft.nl/?f=[will result in an error and by default Tomcat will print a stacktrace along with server information such as version. Added a Valve in theserver.xmlconfig that disables these error reports and server information.Could not find out what the proper procedure was to modify the
server.xmlfile, so copied the default in the container, modified it to include the Valve and replaced this in the container.