Skip to content

Conversation

@abtinmo
Copy link
Contributor

@abtinmo abtinmo commented Nov 24, 2025

Hello there,

this PR references the following issue and Ames to implement a note feature for blocking the user.
#14397

I have implemented a test for POST method block-user, let me know if its needed to test the html response of manage-access and user/<name:user>/ as well.

one of the requirements was Show this in the UI when reviewing blocked users, and return it in the relevant API responses. i could not find any API that interacts with UserBlock model, please let me know if I'm missing something.

@abtinmo abtinmo requested a review from nijel as a code owner November 24, 2025 03:08
@nijel
Copy link
Member

nijel commented Nov 24, 2025

I don't think we have an API for this, so it looks complete for now. What I'd like to see is clarification in the help texts that this is an internal note not sent to the user. And please add a changelog entry.

@nijel nijel linked an issue Nov 24, 2025 that may be closed by this pull request
@nijel nijel added this to the 5.15 milestone Nov 24, 2025
@nijel nijel self-assigned this Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.60%. Comparing base (8a12f18) to head (734ef5a).
⚠️ Report is 1 commits behind head on main.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abtinmo abtinmo requested a review from AliceVisek as a code owner November 27, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Allow a comment/note when blocking a user

2 participants