Replace line breaks with space in MSExcel formulas

[JoHoGH]

This is a suggestion to remove line breaks from formulas when unpacking MSExcel files so the formula is not broken across multiple lines in Winmerge. Line breaks are often added to improve readability in the MSExcel formula bar, but they are not of any interest when looking for differences.

[sdottaka]

Thank you for the PR.
In the table comparison window, enabling View → Wrap Text makes WinMerge display actual line breaks within cells.
Since this is often useful, I’d prefer not to always replace line breaks with spaces.
Could this conversion be made optional instead?

[JoHoGH]

Thanks for looking! Currently, formulas with line breaks do not behave like cell values with line breaks. In the current version any line breaks in the formula creates separate line in the table and changing "Wrap text" does not change that.
For example:

will look like this in Winmerge table comparison (with Wrap Text off)

With my proposed change it gives this

[JoHoGH]

Hi. I tried a different approach using the quoteIfNeeded function to preserve the line breaks in the formula. Code change and result are below. Personally I prefer my earlier version that changed line breaks to space
Result (Wrap text selected)

Code change

[sdottaka]

Sorry, I misunderstood — I thought you were replacing line breaks with spaces for all cell values, not just formulas.
Quoting formulas with double quotes makes them very hard to read, so I agree that’s not a good approach.

However, I still don’t think replacing line breaks should be the default. It would be better to make it configurable via an option.