Extract toolchain variant build steps from advanced.yml to variant.yml
#319
+435
−341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackhex
changed the title
advanced.yml to variant.ymladvanced.yml to variant.yml
Blackhex
force-pushed
the
variant-yml
branch
6 times, most recently
from
7f91326 to
c20c9ba
Compare
Blackhex
commented
May 30, 2025
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
Member
Author
There was a problem hiding this comment.
To be reverted before merge.
Blackhex
commented
May 30, 2025
| branches: | ||
| - main | ||
| pull_request: | ||
| workflow_dispatch: |
Member
Author
There was a problem hiding this comment.
To be reverted before merge.
Blackhex
commented
May 30, 2025
| rebase_branch: | ||
| description: 'Name of temporary branch used to verify the rebase' | ||
| required: true | ||
| default: 'rebase-upstream' |
Member
Author
There was a problem hiding this comment.
To be reverted before merge.
Blackhex
commented
May 30, 2025
| ORIGIN_BRANCH: ${{ inputs.origin_branch || 'woarm64' }} | ||
| UPSTREAM_BRANCH: ${{ inputs.upstream_branch || 'master' }} | ||
| REBASE_BRANCH: ${{ inputs.rebase_branch || 'rebase-upstream' }} | ||
| REBASE_BRANCH: ${{ inputs.rebase_branch || 'woarm64' }} |
Member
Author
There was a problem hiding this comment.
To be reverted before merge.
Blackhex
commented
May 30, 2025
|
|
||
| jobs: | ||
| start-binutils-rebase: | ||
| if: false |
Member
Author
There was a problem hiding this comment.
This and all the following if: false to be reverted before merge.
Blackhex
commented
May 30, 2025
| ${{ env.BACKUP_BRANCH }} | ||
| build: | ||
| needs: [ |
Member
Author
There was a problem hiding this comment.
To be reverted before merge.
Blackhex
commented
May 30, 2025
| gcc_branch: ${{ inputs.rebase_branch || 'rebase-upstream' }} | ||
| mingw_branch: ${{ inputs.rebase_branch || 'rebase-upstream' }} | ||
| cygwin_branch: ${{ inputs.rebase_branch || 'rebase-upstream' }} | ||
| binutils_branch: ${{ inputs.rebase_branch || 'woarm64' }} |
Member
Author
There was a problem hiding this comment.
To be reverted before merge.
Blackhex
changed the title
advanced.yml to variant.ymladvanced.yml to variant.yml
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the toolchain variant build steps from advanced.yml into a new variant.yml, and updates related workflows to call or adjust to this new workflow.
- Introduce a standalone
variant.ymlworkflow to handle per-variant build logic. - Update
rebase.ymlto rely on the new workflow and disable per-repo rebase jobs. - Adjust triggers in
main.ymland add a new strip script.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/variant.yml | New workflow for building toolchain variants |
| .github/workflows/rebase.yml | Updated to call variant workflow, disable individual rebase jobs |
| .github/workflows/main.yml | Removed the pull_request trigger |
| .github/scripts/strip-host-binaries.sh | Added script for stripping host binaries |
Comments suppressed due to low confidence (1)
.github/workflows/main.yml:6
- Removing the pull_request trigger will disable workflow runs on pull requests. Verify this change aligns with expected CI behavior.
- pull_request:
c92e8d8 to
a75d7bf
Compare
Blackhex
force-pushed
the
upstream-workflow
branch
2 times, most recently
from
517afdb to
de7566d
Compare
Blackhex
force-pushed
the
upstream-workflow
branch
from
de7566d to
5efa435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aspires to detatch and abstract the process of building a single variant of the toolchain from the rest of the process - using it for building tested packages as the size of the
advance.ymlworkflow is alredy getting out of hands. This should help keeping the toolchain build process isolated from the rest of theadvanced.ymlworkflow and also allow to re-use this new workflow for others.