Performance optimization for MNDXRootHandler#15
Open
koliva8245 wants to merge 1 commit intoWoW-Tools:masterfrom
Open
Performance optimization for MNDXRootHandler#15koliva8245 wants to merge 1 commit intoWoW-Tools:masterfrom
koliva8245 wants to merge 1 commit intoWoW-Tools:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a performance optimization for the
FindMNDXPackage()method (for loading the listfile).Instead of looking though the entire
Packagesdictionary and finding the "longest" matching path, instead this creates a dictionary for the paths as keys. Then looks for the "longest" path first and if found returns early.This greatly reduces the load time for Star Craft 2 and Heroes of the Storm.