xv: change FOURCC_RGBA32 to AMD one#2128
Open
stefan11111 wants to merge 1 commit intoX11Libre:masterfrom
Open
Conversation
Initally we used value of DRM_FORMAT_ARGB8888, but it seems than xf86-video-ati has established other value for years. So, change it to well established one. Because we define a different values, this breaks compilation of xf86-video-ati. I am unsure, who is right in this situation, but I guess better to use an established value, to make AMD xorg driver compile. I do not aware about any of the side effects of this change. Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/commit/15412e78c83bf3d15bcd343ccc40afda072d3f9e - glamor: xv: add rgba32 format Signed-off-by: Konstantin <ria.freelander@gmail.com> Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1321>
stefan11111
requested review from
a team,
algrid,
b-aaz,
callmetango,
cepelinas9000,
josephcrowell and
metux
Contributor
|
0x34325241 -> FOURCC('A','R','2','4') I think in our case we can fix change at ati driver (looks it is doable without side effects: https://github.com/X11Libre/xf86-video-ati/blob/e192d6a87495e3b91a1c85c3a2243def23abecd7/src/radeon_textured_video.c#L791 ) |
Contributor
Author
|
@josephcrowell ping |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initally we used value of DRM_FORMAT_ARGB8888, but it seems than xf86-video-ati has established other value for years. So, change it to well established one.
Because we define a different values, this breaks compilation of xf86-video-ati. I am unsure, who is right in this situation, but I guess better to use an established value, to make AMD xorg driver compile.
I do not aware about any of the side effects of this change.
Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/commit/15412e78c83bf3d15bcd343ccc40afda072d3f9e - glamor: xv: add rgba32 format
Part-of: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1321