-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Set CONAN_REMOTE_URL also for forks #5662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can just hardcode both the URL (https://conan.ripplex.io) and the name (xrplf). I had added it like this because env vars cannot be used as a "with" input to call reusable workflows, which I'm using in my CI refactor PR that's still under development. However I suspected this would be an issue in forks, which is now confirmed. Therefore, hardcoding seems to be the only option, and I'll figure out a workaround to pass them to reusable workflows later. |
Perhaps hardcode an env. variable, like I did ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5662 +/- ##
=======================================
Coverage 78.8% 78.8%
=======================================
Files 814 814
Lines 71294 71294
Branches 8368 8369 +1
=======================================
+ Hits 56165 56167 +2
+ Misses 15129 15127 -2 🚀 New features to boost your workflow:
|
…actoring-1 * XRPLF/develop: fix: Modify jobs to use '>>' instead of 'tee' for GITHUB_OUTPUT (#5699) refactor: Revamp CI workflows (#5661) refactor: Decouple net from xrpld and move rpc-related classes to the rpc folder (#5477) Set version to 2.6.0-rc2 docs: Updates list of maintainers and reviewers (#5687) fix: Change log to debug level for AMM offer retrieval and IOU payment check (#5686) fix: Add -Wno-deprecated-declarations for Clang only (#5680) Update .git-blame-ignore-revs for #5657 (#5675) Fix BUILD.md instruction (#5676) Set version to 2.6.0-rc1 fix: Improve logging of the reason to refuse a peer connection (#5664) fix: Make test suite names match the directory name (#5597) chore: Run prettier on all files (#5657) chore: Set CONAN_REMOTE_URL also for forks (#5662) chore: Cleanup bin/ directory (#5660) perf: Optimize hash performance by avoiding allocating hash state object (#5469)
…to ximinez/lending-XLS-66 * XRPLF/ximinez/lending-refactoring-4: fix: Modify jobs to use '>>' instead of 'tee' for GITHUB_OUTPUT (#5699) refactor: Revamp CI workflows (#5661) refactor: Decouple net from xrpld and move rpc-related classes to the rpc folder (#5477) Set version to 2.6.0-rc2 docs: Updates list of maintainers and reviewers (#5687) fix: Change log to debug level for AMM offer retrieval and IOU payment check (#5686) fix: Add -Wno-deprecated-declarations for Clang only (#5680) Update .git-blame-ignore-revs for #5657 (#5675) Fix BUILD.md instruction (#5676) Set version to 2.6.0-rc1 fix: Improve logging of the reason to refuse a peer connection (#5664) fix: Make test suite names match the directory name (#5597) chore: Run prettier on all files (#5657) chore: Set CONAN_REMOTE_URL also for forks (#5662) chore: Cleanup bin/ directory (#5660) perf: Optimize hash performance by avoiding allocating hash state object (#5469)
High Level Overview of Change
This should fix workflow errors for PRs from forks
Context of Change
As stated in https://github.com/XRPLF/rippled/blob/develop/BUILD.md ,
rippledrequires certain workarounds to be applied in external dependencies e.g. to ensure static linking oflibstdc++. This used to be applied by means ofconan export --version . . ., but recently we have switched workflows to use a Conan remote https://conan.ripplex.io where we apply the relevant patches. We decided to put this remote in configuration variable but forgot that configuration variables are not available to PRs built from forks. As a result, PRs such as #5637 will use dependencies without workarounds, causing CI errors.This PR replaces configuration variable with hardcoded
https://conan.ripplex.io, making it possible for PRs from forks to use the Conan remote with workarounds.Type of Change
.gitignore, formatting, dropping support for older tooling)