Skip to content

Conversation

@ximinez
Copy link
Collaborator

@ximinez ximinez commented Aug 22, 2025

High Level Overview of Change

The base branch is release. All releases (including betas) go in release. This PR branch will be pushed directly to release (not squashed or rebased, and not using the GitHub UI).

@ximinez ximinez requested a review from a team as a code owner August 22, 2025 21:37
@ximinez ximinez requested review from bthomee and vlntb and removed request for a team August 22, 2025 21:37
@ximinez ximinez added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Aug 22, 2025
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 78.68852% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.8%. Comparing base (fb89213) to head (c5fe970).
⚠️ Report is 2 commits behind head on release.

Files with missing lines Patch % Lines
include/xrpl/basics/TaggedCache.ipp 80.4% 10 Missing ⚠️
src/xrpld/app/ledger/LedgerHistory.cpp 66.7% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           release   #5723   +/-   ##
=======================================
  Coverage     78.8%   78.8%           
=======================================
  Files          814     814           
  Lines        71305   71345   +40     
  Branches      8351    8350    -1     
=======================================
+ Hits         56196   56235   +39     
- Misses       15109   15110    +1     
Files with missing lines Coverage Δ
include/xrpl/basics/SHAMapHash.h 93.5% <ø> (ø)
include/xrpl/basics/TaggedCache.h 100.0% <ø> (ø)
include/xrpl/basics/partitioned_unordered_map.h 99.2% <ø> (+0.3%) ⬆️
src/libxrpl/protocol/BuildInfo.cpp 98.2% <ø> (ø)
src/xrpld/rpc/handlers/GetCounts.cpp 98.4% <100.0%> (+1.6%) ⬆️
src/xrpld/app/ledger/LedgerHistory.cpp 52.1% <66.7%> (+1.4%) ⬆️
include/xrpl/basics/TaggedCache.ipp 85.6% <80.4%> (-0.6%) ⬇️

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ximinez ximinez merged commit c5fe970 into release Aug 22, 2025
29 checks passed
@ximinez ximinez deleted the release-next branch August 22, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants