Skip to content

Conversation

@Bronek
Copy link
Collaborator

@Bronek Bronek commented Sep 18, 2025

High Level Overview of Change

PermissionDelegation amendment requires more work, so we mark it as "unsupported" for now.

This release candidate is merging to the release branch.

This PR must be merged manually using a push. Do not use the Github UI.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

@Bronek Bronek requested a review from a team as a code owner September 18, 2025 17:24
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.8%. Comparing base (8d01f35) to head (c46888f).
⚠️ Report is 2 commits behind head on release.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           release   #5805   +/-   ##
=======================================
  Coverage     78.8%   78.8%           
=======================================
  Files          814     814           
  Lines        71310   71310           
  Branches      8345    8346    +1     
=======================================
+ Hits         56192   56197    +5     
+ Misses       15118   15113    -5     
Files with missing lines Coverage Δ
src/libxrpl/protocol/BuildInfo.cpp 98.2% <ø> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Bronek Bronek added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Sep 18, 2025
@ximinez ximinez merged commit c46888f into release Sep 18, 2025
29 checks passed
@ximinez ximinez deleted the Bronek/disable_PermissionDelegation branch September 18, 2025 18:59
@ximinez ximinez mentioned this pull request Sep 30, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants