Retire Flow and FlowSortStrands #6054
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JCW <[email protected]>
a1q123456
requested review from
bthomee and
vvysokikh1
and removed request for
a team
Signed-off-by: JCW <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6054 +/- ##
=======================================
Coverage 78.6% 78.6%
=======================================
Files 818 818
Lines 68976 68961 -15
Branches 8267 8233 -34
=======================================
+ Hits 54190 54191 +1
+ Misses 14786 14770 -16
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bthomee
approved these changes
Nov 19, 2025
vvysokikh1
reviewed
Nov 21, 2025
| return TER{tecOVERSIZE}; | ||
| return tesSUCCESS; | ||
| }(); | ||
| auto const expectedTER = tesSUCCESS; |
Collaborator
There was a problem hiding this comment.
no need for this variable
| return USD(0); | ||
| return USD(1996); | ||
| }(); | ||
| auto const expectedUSD = USD(1996); |
Collaborator
There was a problem hiding this comment.
no need for this variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)