refactor(core/txpool): remove unused parameter local #30871

[gzliudan]

Proposed changes

Ref: ethereum#30871

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dc014725-011d-4545-a8a5-239ccba9bfa3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors the legacy txpool by removing an unused local parameter from LegacyPool.validateTx, simplifying the internal validation call path without changing external behavior.

Changes:

• Remove the local parameter from (*LegacyPool).validateTx.
• Update the internal call site in (*LegacyPool).add to match the new signature.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The comment above validateTx still says it enforces local-node heuristic limits ("price and size"), but this helper now only performs state-dependent validation plus XDCZ/XDCX and auth checks (and no longer takes a local flag). Consider updating the comment to reflect what this function actually validates, and/or clarify that pricing/size checks happen in validateTxBasics.

Suggested change

	// validateTx checks whether a transaction is valid according to the consensus
	// rules and adheres to some heuristic limits of the local node (price and size).
	// validateTx performs state-dependent validation of a transaction against the
	// current pool state and consensus rules. It also enforces XDCZ/XDCX-specific
	// constraints and authentication checks. Pricing and size heuristics are enforced
	// earlier in validateTxBasics.