Conversation
Open
1 task
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dogmania
requested changes
Feb 25, 2026
Member
There was a problem hiding this comment.
BaseViewModel 보면 onStart, onFinally가 로딩 상태 처리하라고 만든 거라서 혹시 지금 상황에서 사용하지 않은 이유가 따로 있나요??
| import com.twix.domain.model.enums.AppTextStyle | ||
|
|
||
| @Composable | ||
| internal fun LoadingContent() { |
Member
There was a problem hiding this comment.
기기별로 위치가 달라질 수 있을 거 같아서 가운데 정렬로 해도 되지 않을까요?
| } | ||
|
|
||
| @Composable | ||
| private fun FloatingPlane() { |
Member
There was a problem hiding this comment.
6f, 8f가 반복적으로 사용되니까 변수로 빼는 게 나중에 수정할 때 좋을 거 같아요!
- `offsetY`, `offsetX`, `rotation` 애니메이션에 사용되는 매직 넘버를 상수로 추출하여 가독성 및 유지보수성 향상
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이슈 번호
#99
작업내용
결과물
default.mp4
리뷰어에게 추가로 요구하는 사항 (선택)