Skip to content

Conversation

@fukusuket
Copy link
Collaborator

Closed #80

@fukusuket fukusuket requested a review from Copilot June 30, 2025 00:03
@fukusuket fukusuket self-assigned this Jun 30, 2025
@fukusuket fukusuket added the bug Something isn't working label Jun 30, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a quick-xml compile error and resolves clippy warnings by updating logging macros to use new inline string interpolation and renaming the unescape method to decode.

  • Updated trace and debug log macros to interpolate variables directly
  • Changed method calls from unescape() to decode() for consistency and compilation fixes
  • Applied similar formatting updates consistently across multiple files

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/xml_output.rs Updated trace logging to inline interpolation
src/template_cache.rs Updated trace logging formatting
src/json_output.rs Replaced unescape() with decode() and updated formatting
src/evtx_parser.rs Updated debug and trace statements
src/evtx_chunk.rs Updated debug logging statements with inline formatting
src/binxml/tokens.rs Updated multiple trace logging statements to inline formatting
src/binxml/assemble.rs Updated trace logging for clarity and consistency

@fukusuket fukusuket marked this pull request as ready for review June 30, 2025 13:45
@fukusuket fukusuket requested a review from YamatoSecurity June 30, 2025 13:45
Copy link
Contributor

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit 5159a3d into main Jul 3, 2025
6 checks passed
@YamatoSecurity YamatoSecurity deleted the fix-quick-xml-compile-error branch July 3, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile error with quick-xml v0.38.0

3 participants