fix onion= outbound when proxy= is not specified#106
Closed
GiordanoBruno69 wants to merge 1 commit into
Closed
Conversation
quirk: when zclassic was configured with `onion=127.0.0.1:9050` but WITHOUT also `proxy=127.0.0.1:9050`, it caused outbound onion V3 to silently fail, but inbound V3 was working. this was a bug/quirk inherited from earlier BTC/Zcash code technical cause: When a node uses -onion= without -proxy=, HaveNameProxy() returns false, causing ThreadOpenAddedConnections() to take the Lookup() branch — which silently drops .onion addnode peers since they can't be DNS-resolved. Added support for .onion addresses routing through the NET_ONION proxy even when `proxy=` is not specified along with `onion=`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was a bug/quirk inherited from earlier BTC/Zcash code
quirk: when zclassic was configured with
onion=127.0.0.1:9050but WITHOUT alsoproxy=127.0.0.1:9050, it caused outbound onion V3 to silently fail, but inbound V3 was working.use-case: we want this configuration to work for example in a scenario where you want a node to have IPv4 + IPv6 over regular network, not via proxy (or an independent
proxy=), but then allow Onion V3 exclusively via the onion proxy, as specified just withonion=.proxy=can still be used together withonion=to have a different proxy for IPv4+6, independent from onion proxy/technical cause: When a node uses -onion= without -proxy=, HaveNameProxy() returns false, causing ThreadOpenAddedConnections() to take the Lookup() branch — which silently drops .onion addnode peers since they can't be DNS-resolved.
Added support for .onion addresses routing through the NET_ONION proxy even when
proxy=is not specified along withonion=