fix: task state from/to proto missing reject#622
fix: task state from/to proto missing reject#622oneInsect wants to merge 2 commits intoa2aproject:mainfrom
Conversation
Summary of ChangesHello @oneInsect, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds the missing mapping for the rejected task state in both the ToProto.task_state and FromProto.task_state methods. The changes are straightforward and address the issue described. I've added a comment regarding updating the unit tests to cover this new case.
| case types.TaskState.rejected: | ||
| return a2a_pb2.TaskState.TASK_STATE_REJECTED |
There was a problem hiding this comment.
This new case for types.TaskState.rejected is correct. To ensure this change is properly tested, please update the test_enum_conversions unit test in tests/utils/test_proto_utils.py. The test currently excludes types.TaskState.rejected from the round-trip conversion check. Please update the test to include this new state to ensure it's properly covered.
holtskinner
left a comment
There was a problem hiding this comment.
Please check to ensure this isn't already covered in #572
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕