Fix #4576: Add BSD license detection rule for JLine XML comments #4681
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 15, 2026 13:15
Fixes aboutcode-org#4576 Adds bsd-new_jline_xml.RULE to detect BSD-3-Clause license in JLine POM files License was previously undetected because it was in XML comments Tested on jline-console, applies to jline-style and jline-reader as well Signed-off-by: NullPointer-cell <[email protected]>
Remove ignorable_urls field to fix CI validation test failures Signed-off-by: NullPointer-cell <[email protected]>
The URL in the license text must be declared in ignorable_urls to pass CI validation checks. Signed-off-by: NullPointer-cell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4576
Problem
ScanCode failed to detect BSD-3-Clause license in JLine packages (jline-console, jline-style, jline-reader) because the license is declared in XML comments rather than standard Maven
<licenses>tags.Solution
Added detection rule bsd-new_jline_xml.RULE to recognize the specific BSD license notice pattern found in JLine project POM files.
Testing
✅ Verified detection on jline-console-3.30.4-sources.jar
The same pattern appears in jline-style and jline-reader, so this rule covers all three packages.
Changes
Tasks
Signed-off-by: NullPointer-cell [email protected]