Add missing sRGB conversion when baking mmd_color into sRGB mmd_base_tex#485
Draft
Mysteryem wants to merge 1 commit into
Draft
Add missing sRGB conversion when baking mmd_color into sRGB mmd_base_tex#485Mysteryem wants to merge 1 commit into
Mysteryem wants to merge 1 commit into
Conversation
Clean up messy control flow with lots of break and continue statements Always remove all extra material output nodes instead of only sometimes depending on node order Set PrincipledBSDF Base Color default_value instead of creating and saving a blank generated image of the required color Add common functions for faster reading and writing of image pixels
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Image.pixelsis always accessed in scene linear colorspace, but if the image is set to use sRGB colorspace, when it is used in shader nodes, Blender automatically converts it to sRGB. Blender's automatic conversion to sRGB has to be taken into account when multiplyingImage.pixelsby a linear color in order to match the same result of multiplying the image and color using shader nodes.As a small note to avoid confusion, the MMD Ambient Color was previously being referred to as AO, when it is actually Ambient Light.