Remove redundant force-include in pyproject.toml#5
Open
ryanb96 wants to merge 1 commit into
Open
Conversation
The packages = ["autoupdate"] declaration already includes the autoupdate/bootstrappers/ subdirectory in the wheel. The [tool.hatch.build.targets.wheel.force-include] block re-adds the same path, which hatch 1.8+ refuses with: ValueError: A second file is being added to the wheel archive at the same path: `autoupdate/bootstrappers/bootstrap-lin.sh`. Removing the redundant block lets pip install succeed. The resulting wheel still contains all four bootstrappers (bootstrap-lin.sh, bootstrap-mac.sh, bootstrap.exe, bootstrap.pb) via the package include — verified locally with python -m build on Python 3.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
[tool.hatch.build.targets.wheel.force-include]block frompyproject.toml. It re-addsautoupdate/bootstrappers/at the same path thatpackages = ["autoupdate"]already covers.Why
pip installagainst current master fails on hatch 1.8+ with:Verification
Tested locally with Python 3.12 + hatchling latest:
python -m buildfails with the error above.autoupdate/bootstrappers/bootstrap-lin.shautoupdate/bootstrappers/bootstrap-mac.shautoupdate/bootstrappers/bootstrap.exeautoupdate/bootstrappers/bootstrap.pbSince these all live under
autoupdate/,packages = ["autoupdate"]already pulls them in — removing the explicit force-include doesn't change what ends up in the wheel, just stops the duplicate-file conflict.Thanks for maintaining these libraries.