Clean up identifier char handling in keyword lookahead functions #1383
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ES6, identifiers can also contain astral Unicode code points.
This PR adjusts
isAsyncFunctionandto handle this correctly.isUsingKeywordAlso, removes redundant check for backslash inisLet(as potential backslash is already tokenized as part of an identifier token).UPDATE: I just realized that
isIdentifierCharchecks for astral characters when theastralargument is omitted. So this PR just cleans up and makes things more consistent.