Adding information in the commandline tool help to prevent accidental discharge during clamshell mode#296
Open
iamchanghyunpark wants to merge 4 commits intoactuallymentor:mainfrom
Open
Conversation
Without reading the issues, I enabled battery discharge on the commandline (while using the laptop in clamshell mode). I had to jump through a few hoops to get clamshell mode working again. Thus, probably best to warn users not to use the `battery discharge` command if they are using it in clamshell mode.
Updates the `battery` command output to include the warning about using `battery discharge` with clamshell mode.
Owner
|
Ah nice one. Could you rephrase it to "does not work properly in clamshell mode" for clarity? |
Clarified warning about clamshell mode in discharge command.
Author
|
Sorry, the update should have been a single commit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
battery dischargeshould not be used with clamshell mode. (Laptop just goes to sleep) These two commits add information to thebatterycommandline tool output and theREADME.mdthat also prints the output of thebatterycommandline tool that warns against usingbattery dischargewhile in clamshell mode.