Skip to content

Conversation

@ZixuanZhang-96
Copy link

@ZixuanZhang-96 ZixuanZhang-96 commented Apr 15, 2025

as titled

.map(ts => ts.filterNot(t => excluded contains t.name.name))
.map (
ts =>
(if (included.isEmpty) ts else ts.filter(t => containsTable(included, t)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious why not just use two filters instead of this complex map..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no difference between using two maps each with a filter, and using one map with two filters.
comments added

Copy link

@huayangdu huayangdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZixuanZhang-96 ZixuanZhang-96 merged commit 66f4065 into master Apr 18, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants