Skip to content

Fix: prevent error when local plugin not found (fixes #219) #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Fix: prevent error when local plugin not found (fixes #219) #220

merged 1 commit into from
Jul 7, 2025

Conversation

@chris-steele
Copy link
Contributor

@chris-steele chris-steele commented Jun 9, 2025

#219

Fix

  • Prevent error when local plugin not found

@chris-steele chris-steele self-assigned this Jun 9, 2025
@chris-steele chris-steele moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jun 9, 2025
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@taylortom
Copy link
Member

taylortom commented Jun 10, 2025

What are the steps to test this one?

@chris-steele
Copy link
Contributor Author

chris-steele commented Jun 10, 2025

@taylortom the scenario I had was that APP_DATA was missing and I was using an existing database that had references to local plugins. This fix prevents an reference error that halts full installation of the framework and other plugins. FYI the contentplugin module will log which plugins are missing.

@swashbuck swashbuck linked an issue Jun 17, 2025 that may be closed by this pull request
Prevent error when local plugin not found #219
Closed
@joe-allen-89 joe-allen-89 merged commit e67be8f into master Jul 7, 2025
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/219 branch July 7, 2025 10:25
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jul 7, 2025
github-actions bot pushed a commit that referenced this pull request Jul 7, 2025
@semantic-release-bot
Chore(release): 3.3.3 [skip ci]
537aa1d 
## [3.3.3](v3.3.2...v3.3.3) (2025-07-07)

### Fix

* Prevent error when local plugin not found (fixes #220) ([e67be8f](e67be8f)), closes [#220](#220)
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

🎉 This PR is included in version 3.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@taylortom taylortom Awaiting requested review from taylortom

Assignees

@chris-steele chris-steele

Labels

bug released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent error when local plugin not found

6 participants

@chris-steele @taylortom @oliverfoster @cahirodoherty-learningpool @joe-allen-89