Skip to content

Conversation

@navratan-soni
Copy link
Contributor

Created AEPViewModel class and updated sample app to use the same

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (b11aa75) to head (1b7de41).

Files with missing lines Patch % Lines
.../aepcomposeui/viewmodel/AepContentCardViewModel.kt 52.63% 7 Missing and 2 partials ⚠️
...iewmodel/factory/AepContentCardViewModelFactory.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             feature/content-cards     #314      +/-   ##
===========================================================
- Coverage                    80.33%   80.11%   -0.22%     
  Complexity                     799      799              
===========================================================
  Files                           78       80       +2     
  Lines                         3691     3716      +25     
  Branches                       568      571       +3     
===========================================================
+ Hits                          2965     2977      +12     
- Misses                         583      594      +11     
- Partials                       143      145       +2     
Flag Coverage Δ
functional-tests 30.70% <0.00%> (-0.21%) ⬇️
unit-tests 79.73% <40.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spoorthipujariadobe spoorthipujariadobe marked this pull request as draft March 25, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant