This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Display error message for invalid zip errors#69
Open
marcelgerber wants to merge 1 commit intoadobe:masterfrom
marcelgerber:invalid-zip-error-message
Open
Display error message for invalid zip errors#69marcelgerber wants to merge 1 commit intoadobe:masterfrom marcelgerber:invalid-zip-error-message
marcelgerber wants to merge 1 commit intoadobe:masterfrom
marcelgerber:invalid-zip-error-message
Conversation
|
@marcelgerber You need to update package-validator.js in Brackets, and then update brackets-extensibility.tgx from Brackets. |
Member
|
@marcelgerber Does the .tgz change here still match the package-validator change that landed in adobe/brackets#10343? If so then @redmunds is this ok to merge now? |
Contributor
Author
|
It doesn't include the updated version number in package.json. |
Collaborator
|
I assume we are waiting for adobe/brackets#10372 to land |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an error occurs in decompressZip, the returned error will be displayed to the user.
This hopefully helps tracking down adobe/brackets#7387.
Diff of
package-validator.js:function extractAndValidateFiles(zipPath, extractDir, options, callback) { var unzipper = new DecompressZip(zipPath); unzipper.on("error", function (err) { // General error to report for problems reading the file callback(null, { - errors: [[Errors.INVALID_ZIP_FILE, zipPath]] + errors: [[Errors.INVALID_ZIP_FILE, zipPath, err]] }); return; });