This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Incorporating changes for the brackets-registry redesign#82
Open
Incorporating changes for the brackets-registry redesign#82
Conversation
shubhsnov
changed the title
narayani28
reviewed
Jan 24, 2018
README.md
Outdated
|
|
||
| - Requirements | ||
| - Git command line tools — follow the setup instructions on [GitHub](https://help.github.com/articles/set-up-git) or download [here](http://git-scm.com/downloads) | ||
| - [NodeJS installed](https://nodejs.org/en/download/current/) |
There was a problem hiding this comment.
Mention the node version. The current version might break some features in the future.
narayani28
reviewed
Jan 24, 2018
public/img/LICENSE.txt
Outdated
| to represent the company, product, or service to which they refer.** | ||
|
|
||
| ################################################################################# | ||
| Modified by Adobe Systems Incorporated 2017. |
narayani28
reviewed
Jan 24, 2018
| @@ -0,0 +1,118 @@ | |||
| <!-- Header Section --> | |||
There was a problem hiding this comment.
i assume this is the new page that you have added.Is the registry site localized ? if yes, this new page should support localization for the same set of languages that the original registry site supports.
Author
There was a problem hiding this comment.
Registry page doesn't support localization.
narayani28
reviewed
Jan 24, 2018
narayani28
left a comment
narayani28
left a comment
There was a problem hiding this comment.
Have you run linting for all the changes here in this review?
Author
|
We have an automatic lint checker, that can be accessed via running "npm run lint". Linting test passed. |
narayani28
approved these changes
Jan 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the registry side changes that were done as part of the brackets website redesign.
This covers:
SIte can be visually reviewed at https://54.245.134.35
ping @nethip and @swmitra for review.