Skip to content

MWPW-190760: OST dynamic % discount followup#720

Merged
Roycethan merged 7 commits intomainfrom
MWPW-190760
Apr 16, 2026
Merged

MWPW-190760: OST dynamic % discount followup#720
Roycethan merged 7 commits intomainfrom
MWPW-190760

Conversation

@Axelcureno
Copy link
Copy Markdown
Member

@Axelcureno Axelcureno commented Mar 26, 2026

Resolves https://jira.corp.adobe.com/browse/MWPW-190760

Follow-up from MWPW-188582. Fixes three issues with the discount feature:

  1. OST bundle rebuild — Updated with initialReferenceOsi support so dual-OSI discounts re-open correctly (first OSI in search, second in discount field)
  2. Badge font-size fix — Badge and trial badge RTE fields now use --spectrum-font-size-100 to match sp-textfield sizing
  3. Nala tests — Added discount badge visibility and edit/discard tests (6/6 passing)

Related PRs

Test URLs

Checklist

  • Code follows project conventions
  • Linter runs without errors
  • Studio unit tests pass (1412 passed, 1 pre-existing failure in translation)
  • Nala tests pass (6/6)
  • Backward compatible

@Axelcureno
MWPW-190760: OST discount followup fixes
6b87ec0 
- Rebuild OST bundle with initialReferenceOsi support for dual-OSI
  discount re-open
- Fix badge/trial badge font size in editor to match sp-textfield
- Add Nala tests for discount badge visibility and edit/discard
@aem-code-sync
Copy link
Copy Markdown

aem-code-sync bot commented Mar 26, 2026 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.35%. Comparing base (41523a0) to head (cd1503a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   87.38%   87.35%   -0.04%     
==========================================
  Files         209      209              
  Lines       62388    62389       +1     
==========================================
- Hits        54518    54500      -18     
- Misses       7870     7889      +19
Files with missing lines Coverage Δ
studio/src/rte/rte-field.js 77.34% <100.00%> (+0.01%) ⬆️

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41523a0...cd1503a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Axelcureno Axelcureno self-assigned this Apr 2, 2026
@Axelcureno
MWPW-190760: Address pinata-agent review nits in discount.test.js
35a2270 
- Remove unused plans import
- Replace waitForTimeout(500) with toBeFocused() assertion after badge click
- Remove redundant waitForTimeout(1000) — step-4 not.toBeVisible() acts as sync barrier
Roycethan
Roycethan requested changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Axelcureno The Reference offer OSI is not saved after re-opening the badge discount
https://mwpw-190760--mas--adobecom.aem.live/studio.html#fragmentId=f6defd08-ed85-49fb-83ec-a84ad7298ffa&page=fragment-editor&path=sandbox

Image

@Axelcureno
MWPW-190760: rebuild OST bundle with initialReferenceOsi support
7365ddd 
Update the OST bundle to include the AppContext.js fix that threads
initialReferenceOsi through createAppContext, so the discount reference
OSI field is prepopulated when re-opening an existing dual-OSI discount.
@Axelcureno Axelcureno requested a review from Roycethan April 16, 2026 03:09
@Axelcureno
Copy link
Copy Markdown
Member Author

Axelcureno commented Apr 16, 2026

@Axelcureno The Reference offer OSI is not saved after re-opening the badge discount https://mwpw-190760--mas--adobecom.aem.live/studio.html#fragmentId=f6defd08-ed85-49fb-83ec-a84ad7298ffa&page=fragment-editor&path=sandbox

Image

Fixed. please try again with the same link

@Roycethan
Copy link
Copy Markdown
Collaborator

Roycethan commented Apr 16, 2026

@Axelcureno The Reference offer OSI is not saved after re-opening the badge discount https://mwpw-190760--mas--adobecom.aem.live/studio.html#fragmentId=f6defd08-ed85-49fb-83ec-a84ad7298ffa&page=fragment-editor&path=sandbox
Image

Fixed. please try again with the same link

Yes its fixed

@Roycethan Roycethan merged commit b051b43 into main Apr 16, 2026
21 of 25 checks passed
@Roycethan Roycethan deleted the MWPW-190760 branch April 16, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesil yesil yesil approved these changes

@mirafedas mirafedas mirafedas approved these changes

@antonio-rmrz antonio-rmrz antonio-rmrz approved these changes

@Roycethan Roycethan Roycethan approved these changes

@joaquinrivero joaquinrivero Awaiting requested review from joaquinrivero

@seanchoi-dev seanchoi-dev Awaiting requested review from seanchoi-dev

Assignees

@Axelcureno Axelcureno

Labels

run nala verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Axelcureno @Roycethan @yesil @mirafedas @antonio-rmrz