Conversation
Owner
|
It seems the gem cached the result of the offline response. Not found requests are the slowest and need to be cached. We should see if the result is offline vs not found. |
We can't tell (in Ruby?) that the network is down, so if a dns lookup returned a SocketError, it can mean either not found or network unavailable. Until I find a better way, I test the network on that exception by looking up "example.com". If it works, then assume it was a not-found condition. For unavailable, a dummy record is returned. Also, moved the a-record lookup into the same exchanger object, with the same network test. Exchanger objects are cached. When I pull it out of the cache, I check to see if the network-down occurred, and if so, throw it away and create a new one so it can work properly when the network becomes available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Validation gives inconsistent results depending on network status.
Reproduction:
Turn off your network connection.
Do the following:
Turn your network connection back on.
In the same IRB session, with connectivity restored:
Start a new IRB session:
Expected Behavior: Seems like if there's no network connection, it should raise a warning about MX not being able to validate, not report that validation has failed. Also, it definitely shouldn't report
"This domain is not configured to accept email"aboutgmail.comat any point. Whatever is giving that report on that domain is pretty much by definition incorrect.