Open
Conversation
fernandojsg
reviewed
Dec 22, 2016
src/brushes/snow.js
Outdated
Member
There was a problem hiding this comment.
what does subdivisions means? I believe it should be ' * FLAKES_PER_POINT` isn't it?
Contributor
Author
|
good catch, i didn't notice the thousands of flakes drawing at exactly 0,0,0. Updated. |
Member
|
…random in the vertex shader, cap the minimum flake size
Contributor
Author
|
Ok updated all three
|
Member
Member
|
Nice addition! I would animate the rotation and add some scale variation to the flakes, but it is nice as it is too :) I tested the last commit, and everything looks fine, but:
Merry Christmas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The holidays are almost here, and i've lived in california so long i've forgotten that there's supposed to be snow!
I've implemented a falling snow brush, that uses a point-sprite cloud, and vertex shaders to make them fall nicely.
I also added a binary=true flag for the loading of a demo.apa file which seems to have broken