feat: add configurable progress bar to SVG output#9
Open
xav-ie wants to merge 1 commit intoagentstation:mainfrom
Open
feat: add configurable progress bar to SVG output#9xav-ie wants to merge 1 commit intoagentstation:mainfrom
xav-ie wants to merge 1 commit intoagentstation:mainfrom
Conversation
Add a "Set ProgressBar <color>" command that renders an animated 1px bar at the bottom of the SVG that grows left to right over the animation duration. Supports #RGB, #RRGGBB, and #RRGGBBAA hex colors. The progress bar is opt-in — it only renders when a color is explicitly set. The default (no setting) produces no progress bar, keeping existing behavior unchanged. The bar is placed inside the inner SVG element so its CSS animation applies correctly in both browsers and non-browser renderers (librsvg, Inkscape, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set ProgressBar <color>command to tape files for an animated progress bar in SVG output#RGB,#RRGGBB, and#RRGGBBAAhex colors (RGBA for semi-transparent bars)Usage
For a semi-transparent bar:
Implementation
Test plan
TestParseProgressBar— valid hex colors (#RGB, #RRGGBB, #RRGGBBAA) parse correctly; invalid colors produce errorsTestSVGGenerator_ProgressBar— no bar by default, renders with color, supports RGBA, bar is inside inner SVG, animation duration matches slidego test ./...)