fix: return differentiated errors from InsertedGER::verify instead of bool#262
Open
VolodymyrBg wants to merge 2 commits intoagglayer:mainfrom
Open
fix: return differentiated errors from InsertedGER::verify instead of bool#262VolodymyrBg wants to merge 2 commits intoagglayer:mainfrom
VolodymyrBg wants to merge 2 commits intoagglayer:mainfrom
Conversation
Contributor
Ekleog-Polygon
left a comment
There was a problem hiding this comment.
Conceptually this LGTM! Unfortunately we can't accept external contributions yet. We'll come back to you once the process for external contributors is defined.
Also, this is more a matter of implementation, but IMO GerVerificationError, considering it's only used at a single place for now, would deserve being a ZST like pub struct GerVerificationError; :)
Thank you for your PR anyway!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace boolean return type with Result<(), GerVerificationError> in InsertedGER::verify
This change provides better error handling and debugging capabilities
by giving specific information about what went wrong during GER verification.
The function now returns meaningful error messages instead of just true/false,
making it easier to diagnose issues in production environments.