chore: fix build script to always run from repo root#299
chore: fix build script to always run from repo root#299mdqst wants to merge 1 commit intoagglayer:mainfrom
Conversation
|
Hi atanmarko ty for the update. I completely understand the need to wait for legal approval before accepting external contributions. wanted to briefly highlight that this PR improves the script so it now works reliably no matter where it is run from. specifically, it:
this ensures a more robust and consistent workflow for anyone using the script. please let me know if there’s any additional information or clarification I can provide to help the legal team evaluate it, I’m happy to assist in any way. ty for your time and consideration. |
|
|
||
| echo "Building the docker images. Note this script should be run from the repository root." | ||
| docker build -t aggkit-prover:local . | ||
| SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" |
There was a problem hiding this comment.
I'm wondering if something like the following would be enough:
SCRIPT_DIR="$(dirname "$0")"
It might treat symlinks a bit differently but is it an issue?
Also, the echo message saying the script should run from the root will be outdated with this change.
switched the shebang to bash, added
SCRIPT_DIR+REPO_ROOT, and updateddocker buildto always use the repo root.now the script works no matter where you run it from.