Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
update proper message spacing
DerekAgility
reviewed
Apr 7, 2026
| > | ||
| {({ selected }) => ( | ||
| <div className="py-xxsm px-sm flex items-center gap-xsm"> | ||
| <span>{option.label}</span> |
Contributor
There was a problem hiding this comment.
We should be using our own Typography here
Comment on lines
+169
to
+170
| <span className="text-neutral-500 font-normal">{option.description}</span> | ||
| ) : null} |
|
|
||
| # The required yarn version to use this script | ||
| REQUIRED_YARN_VERSION="1.22.19" | ||
| REQUIRED_YARN_VERSION="1.22.22" |
Contributor
There was a problem hiding this comment.
was this added by mistake?
Contributor
Author
There was a problem hiding this comment.
I wasn't able to run locally without this set to that version. I wasn't sure if I should upload this here for future or if I just keep it locally.
Contributor
There was a problem hiding this comment.
Running storybook? Are you running yarn dev?
Contributor
Author
There was a problem hiding this comment.
Yep I do yarn run dev
Contributor
There was a problem hiding this comment.
Hmmm interesting, let's merge this in and see what happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the native
<select>element with a fully styled HeadlessUI Combobox, adding new props and fixing several edge cases.What changed
stories/molecules/inputs/select/Select.tsx<select>with@headlessui/reactCombobox (read-only mode) for fullstyling control with built-in accessibility
ResizeObserverso it always matches — even insideanimated modals
z-[9999]to always appear above modal contentdescriptiontoISimpleSelectOptionswhich renders inline next to the label inmuted text
New props
dropdownMaxHeightnumber240placeholderstring"Select"