Skip to content

Commit f40c8d5

Browse files
committed
small fix
1 parent 237b62c commit f40c8d5

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

tests/utils/managed_deployment.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -332,13 +332,13 @@ def set_service_env_var(self, service_name: str, name: str, value: str):
332332
service.envs = []
333333

334334
# if env var already exists, update it
335-
for env in service["envs"]:
335+
for env in service.envs:
336336
if env["name"] == name:
337337
env["value"] = value
338338
return
339339

340340
# if env var does not exist, add it
341-
service["envs"].append({"name": name, "value": value})
341+
service.envs.append({"name": name, "value": value})
342342

343343
def get_service_env_vars(self, service_name: str) -> list[dict]:
344344
"""
@@ -377,23 +377,24 @@ def add_arg_to_service(self, service_name: str, arg_name: str, arg_value: str):
377377
arg_value: Argument value (e.g., "1024")
378378
"""
379379
service = self.get_service(service_name)
380+
service_spec = service._spec
380381

381382
# Ensure args list exists
382-
if "extraPodSpec" not in service:
383-
service["extraPodSpec"] = {"mainContainer": {}}
384-
if "mainContainer" not in service["extraPodSpec"]:
385-
service["extraPodSpec"]["mainContainer"] = {}
386-
if "args" not in service["extraPodSpec"]["mainContainer"]:
387-
service["extraPodSpec"]["mainContainer"]["args"] = []
383+
if "extraPodSpec" not in service_spec:
384+
service_spec["extraPodSpec"] = {"mainContainer": {}}
385+
if "mainContainer" not in service_spec["extraPodSpec"]:
386+
service_spec["extraPodSpec"]["mainContainer"] = {}
387+
if "args" not in service_spec["extraPodSpec"]["mainContainer"]:
388+
service_spec["extraPodSpec"]["mainContainer"]["args"] = []
388389

389-
args_list = service["extraPodSpec"]["mainContainer"]["args"]
390+
args_list = service_spec["extraPodSpec"]["mainContainer"]["args"]
390391

391392
# Convert to list if needed (sometimes it's a single string)
392393
if isinstance(args_list, str):
393394
import shlex
394395

395396
args_list = shlex.split(args_list)
396-
service["extraPodSpec"]["mainContainer"]["args"] = args_list
397+
service_spec["extraPodSpec"]["mainContainer"]["args"] = args_list
397398

398399
# Find existing argument
399400
arg_index = None

0 commit comments

Comments
 (0)