Skip to content

fix: TRT-LLM cache transceiver setting issue since 1.2.0rc3 #4703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kthui merged 4 commits into from
Dec 16, 2025
Merged

fix: TRT-LLM cache transceiver setting issue since 1.2.0rc3 #4703

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ae7e13
fix: Set max_tokens_in_buffer on TRT-LLM cache transceiver
kthui Dec 2, 2025
a177dfa
test: Switch from memory utilization to setting kv_cache max_tokens
kthui Dec 12, 2025
b88c58f
test: Update timeout accounting for reduced KV cache size
kthui Dec 13, 2025
85621a2
tmp: Allow kv transfer cancel test to fail on CI
kthui Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions tests/fault_tolerance/cancellation/test_trtllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
# SPDX-License-Identifier: Apache-2.0

"""
Test Execution Times (Last Run: 2025-12-09):
Test Execution Times (Last Run: 2025-12-13):
- test_request_cancellation_trtllm_aggregated: ~45s (gpu_1)
- test_request_cancellation_trtllm_decode_cancel: ~115s (gpu_1)
- test_request_cancellation_trtllm_prefill_cancel: ~115s (gpu_1)
- test_request_cancellation_trtllm_kv_transfer_cancel: ~115s (gpu_1, xfail)
- Total: ~390s (0:06:30)
- test_request_cancellation_trtllm_decode_cancel: ~65s (gpu_1)
- test_request_cancellation_trtllm_prefill_cancel: ~65s (gpu_1)
- test_request_cancellation_trtllm_kv_transfer_cancel: ~65s (gpu_1)
- Total: ~240s x2 request planes = ~480s (0:08:00)
"""

import logging
Expand Down Expand Up @@ -72,8 +72,6 @@ def __init__(
FAULT_TOLERANCE_MODEL_NAME,
"--disaggregation-mode",
mode,
"--free-gpu-memory-fraction",
"0.45",
"--max-seq-len",
"16384",
"--max-num-tokens",
Expand All @@ -83,8 +81,11 @@ def __init__(
]
if mode != "prefill_and_decode":
with open("test_request_cancellation_trtllm_config.yaml", "w") as f:
f.write("cache_transceiver_config:\n backend: DEFAULT\n")
f.write(
"cache_transceiver_config:\n backend: DEFAULT\n max_tokens_in_buffer: 16384\n"
)
f.write("disable_overlap_scheduler: true\n")
f.write("kv_cache_config:\n max_tokens: 16384\n")
command += [
"--extra-engine-args",
"test_request_cancellation_trtllm_config.yaml",
Expand Down Expand Up @@ -164,7 +165,7 @@ def __exit__(self, exc_type, exc_val, exc_tb):
return super().__exit__(exc_type, exc_val, exc_tb)


@pytest.mark.timeout(140) # 3x average
@pytest.mark.timeout(135) # 3x average
def test_request_cancellation_trtllm_aggregated(
request, runtime_services_dynamic_ports, predownload_models
):
Expand Down Expand Up @@ -251,7 +252,7 @@ def test_request_cancellation_trtllm_aggregated(
logger.info(f"{description} detected successfully")


@pytest.mark.timeout(350) # 3x average
@pytest.mark.timeout(195) # 3x average
def test_request_cancellation_trtllm_decode_cancel(
request, runtime_services_dynamic_ports, predownload_models
):
Expand Down Expand Up @@ -335,7 +336,7 @@ def test_request_cancellation_trtllm_decode_cancel(
)


@pytest.mark.timeout(350) # 3x average
@pytest.mark.timeout(195) # 3x average
def test_request_cancellation_trtllm_prefill_cancel(
request, runtime_services_dynamic_ports, predownload_models
):
Expand Down Expand Up @@ -427,11 +428,8 @@ def test_request_cancellation_trtllm_prefill_cancel(
)


@pytest.mark.timeout(350) # 3x average
@pytest.mark.xfail(
reason="May fail due to unknown reason with TRT-LLM or backend implementation",
strict=False,
)
@pytest.mark.xfail(reason="Test fails only on CI", strict=False)
@pytest.mark.timeout(195) # 3x average
def test_request_cancellation_trtllm_kv_transfer_cancel(
request, runtime_services_dynamic_ports, predownload_models
):
Expand Down
Loading